[Sugar-devel] GCI pull requests

Manuel Quiñones manuq at laptop.org
Tue Dec 3 13:49:15 EST 2013


2013/12/2 Daniel Narvaez <dwnarvaez at gmail.com>:
> Hello,
>
> for the GCI pull requests which implements a new feature or UI change, I
> wonder if we should ask students to post an email with a link to their
> branch to the mailing list, instead of a pull request. The pull request
> would be submitted after consensus on the feature was reached.
>
> I think the current workflow is too much work for the reviewers... We need
> to spend time getting the code right for something which might not even want
> to land and we need to take care of starting and following a mailing list
> thread for the design discussion.

Yes, +1.

Features always need discussions.  Working code is always better, but
we need to agree on design first, otherwise is more work for everyone.

-- 
.. manuq ..


More information about the Sugar-devel mailing list