[Sugar-devel] GCI pull requests
Walter Bender
walter.bender at gmail.com
Mon Dec 2 09:31:16 EST 2013
+1
I can ask them (GCI students) o change their protocol
-walter
On Mon, Dec 2, 2013 at 8:57 AM, Daniel Narvaez <dwnarvaez at gmail.com> wrote:
> Hello,
>
> for the GCI pull requests which implements a new feature or UI change, I
> wonder if we should ask students to post an email with a link to their
> branch to the mailing list, instead of a pull request. The pull request
> would be submitted after consensus on the feature was reached.
>
> I think the current workflow is too much work for the reviewers... We need
> to spend time getting the code right for something which might not even want
> to land and we need to take care of starting and following a mailing list
> thread for the design discussion.
>
> (To be clear I'm talking only about features here, not bug fixes)
>
>
> --
> Daniel Narvaez
>
>
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>
--
Walter Bender
Sugar Labs
http://www.sugarlabs.org
More information about the Sugar-devel
mailing list