[Sugar-devel] [PATCH] Color Palette: get back horizontal padding - SL #4325
Manuel Quiñones
manuq at laptop.org
Wed Apr 24 13:21:22 EDT 2013
2013/4/24 Simon Schampijer <simon at schampijer.de>:
> On 04/19/2013 03:51 PM, Manuel Quiñones wrote:
>>
>> 2013/4/18 Simon Schampijer <simon at schampijer.de>:
>>>
>>> Hi Manuel,
>>>
>>> your patch does fix the Write-Color-Palette.
>>>
>>> Which is the Abacus-Palette, the custom one? Is Walter aware of this fix
>>> and
>>> would remove his workaround (at least in master)?
>>
>>
>> Yes, the Abacus palette is the custom one. I'm prepared to let Walter
>> know about this change at the moment its commited so he can remove the
>> workaround. Gonzalo workarounded Paint too.
>>
>>> Code looks good, please push, as well to 0.98.
>>
>>
>> I have sent a new patch which adds padding as optional parameter. I
>> think it is better API. What do you think?
>>
>> --
>> .. manuq ..
>
>
> The API is good, but as you add API you can not push as-is to the 0.98
> branch. You can push the first one there.
Ok! As it was adding an optional argument I thought we could. By the
way the first one was merged in master already, so I will cherrypick
from there before next release.
Thanks,
--
.. manuq ..
More information about the Sugar-devel
mailing list