[Sugar-devel] Reviews experiment

Manuel Quiñones manuq at laptop.org
Wed Apr 3 16:04:46 EDT 2013


2013/4/3 Daniel Narvaez <dwnarvaez at gmail.com>:
> Hello,
>
> we now have a list of reviewers but we still need to figure out a good
> review workflow.
>
> I and Walter have been playing with github pull requests in the past few
> days. Let's try to extend the experiment to everyone and test if it really
> works well for us. Essentially this means a couple of things
>
> 1. Patch contributors should submit their code using pull requests. I setup
> forks of the Glucose repositories here (I will take care of syncing back to
> gitorious).
>
> https://github.com/sugarlabs
>
> If you are not familiar with it, see the official github documentation
>
> https://help.github.com/articles/using-pull-requests
>
> 2. Reviewers will get email notifications when new patches are posted.
> Please use the web interface to comment on the changes and request fixes.
> When you are happy with the patch, feel free to merge it. Some info on how
> to do it
>
> https://help.github.com/articles/merging-a-pull-request
>
> There has been some discussion on the list about the details of the
> workflow, but really I would like everyone to try things out before
> documenting the process more precisely. Similarly I'm planning to write a
> checklist reviewers should follow but I'd like that to emerge from the
> experiment.
>
> Let's post any question, doubt or complaint to the list, so that everyone
> can participate in the discussion.

Well done!  I have a patch in the workings for:
http://bugs.sugarlabs.org/ticket/3819

It is a bugfix that brings back the drag and drop to the clipboard
inside the frame.  Will do the pull request when I finish.

.. manuq ..


More information about the Sugar-devel mailing list