[Sugar-devel] Recent movement on Sugar master repository

[Daniel Narvaez]

Hey,

sorry, I forgot about those. Though I think it's worth to think if we
really need them while we are reworking reviews a bit.

When is signed-off-by useful in sugar?

How is reviewed-by applied? Is it the reviewer which rebase and add them
before pushing?

On 2 April 2013 18:30, Manuel Quiñones <manuq at laptop.org> wrote:

> Hi devs,
>
> I've seen some movement in current master.  I suppose all this was
> reviewed, but what I wonder is if we are sticking to the signed-off-by
> / acked-by signing.
>
> The commits in question are:
>
> commit f423ec21b4bf0d953a470a383cc801b61a087e98
> Author: Walter Bender <walter.bender at gmail.com>
> Date:   Sat Mar 30 16:06:00 2013 -0400
>
>     Add comment box to expanded entry
>
> commit 541af0166030a5f3b7b52bdc23d416dbf688b5e9
> Author: Walter Bender <walter.bender at gmail.com>
> Date:   Sat Mar 30 10:45:22 2013 -0400
>
>     Add CommentView widget to expanded entry
>
> commit 248a758875e5a02a53ae57980f4fe2f3bb0bb91e
> Author: Walter Bender <walter.bender at gmail.com>
> Date:   Thu Mar 28 15:26:17 2013 -0400
>
>     Make a separate method for _write_entry so method can be reused
>
> commit 1af4b5ec7f03ed43da1616df946fe936e8577e91
> Author: Walter Bender <walter.bender at gmail.com>
> Date:   Thu Mar 28 15:25:41 2013 -0400
>
>     Pass a widget to _create_scrollable so method can be reused
>
>
> --
> .. manuq ..
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>



-- 
Daniel Narvaez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20130402/ed87286c/attachment.html>