[Sugar-devel] [PATCH 1/7] Add ds_clean flag to trigger index rebuilds #2095, #2317

[Manuel Kaufmann]

On Fri, Sep 21, 2012 at 12:55 AM, Martin Langhoff <martin at laptop.org> wrote:
> This gives us more complete coverage of cases where ENOSPC or
> other errors are hit when creating/updating datastore entries.

I reviewed this patch and I think it's OK. I didn't test it because
I'm not sure how to simulate that scenario.

Just a comment: why you didn't add a callback function
(_delete_completion_cb) to the "delete" method and make create /
update / delete consistent between them? In that method we can add
self._mark_clean

Thought: we are dealing near ENOSPC, right? So, maybe the clean_flag
will not be created (this is already handled in the patch) and this
patch will not take effect the next time the XO restarts and we will
be in the same situation again.

-- 
Kaufmann Manuel
Blog: http://humitos.wordpress.com/
Porfolio: http://fotos.mkaufmann.com.ar/
PyAr: http://www.python.com.ar/