[Sugar-devel] [PATCH sugar 2/2] Add feedback in Home View, List View when there are no matching entries - SL #3838

[Simon Schampijer]

On 09/19/2012 12:28 AM, Manuel Quiñones wrote:
> 2012/9/18 Simon Schampijer <simon at schampijer.de>:
>> Thanks for working on that Manuel!
>>
>> - the EventIcon in the box could be just an Icon, we don't listen for events
>> here (same to the one in the Journal box) (in patch)
>
> Ah you are right!  Good.
>
>> - the attach_to_clear, I would listen to the 'clear-clicked' signal in
>> homebox.py and then call clear_search (in patch)
>
> Thanks I was in doubt with that, yes now I see is better to connect it
> directly in the homebox instead of doing unneded calls.  Thanks for
> the fix.
>
>> - as you already mentioned, would be great to put a generalized clearbox in
>> jarabe/view so it can be used in both places (can be done in a follow up)
>>
>> - the box is a typical candidate for theming in artwork (can be done in a
>> follow up)
>
> Yes I think we can do those items together, we will need only one
> MessageBox class so we can style it in the theme.
>
> Cheers.
>

Excellent, I pushed a follow up to replace the EventIcon with an Icon in 
the Journal message box.

Simon