[Sugar-devel] [PATCH Browse] Don't call .start after .set_destination_uri SL #3878

Manuel Kaufmann humitos at gmail.com
Mon Sep 10 17:11:08 EDT 2012


Do not call WebKitDownload.start after .set_destination_uri because it
is no needed. The download will start automatically after
.set_destination_uri.

http://webkitgtk.org/reference/webkitgtk/stable/webkitgtk-webkitwebview.html#WebKitWebView-download-requested

Signed-off-by: Manuel Kaufmann <humitos at gmail.com>
---
 downloadmanager.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/downloadmanager.py b/downloadmanager.py
index 9950c16..ab9fec2 100644
--- a/downloadmanager.py
+++ b/downloadmanager.py
@@ -85,7 +85,6 @@ class Download(object):
         logging.debug('Download destination path: %s' % self._dest_path)
 
         self._download.set_destination_uri('file://' + self._dest_path)
-        self._download.start()
 
     def __progress_change_cb(self, download, something):
         progress = self._download.get_progress()
-- 
1.7.11.4



More information about the Sugar-devel mailing list