[Sugar-devel] Double Gtk.main_quit (was Re: [PATCH sugar-toolkit-gtk3] Sugar scroll bar clicks should invoke page up/page down SL #3859)

[Daniel Narvaez]

Hello,

I updated most of the modules but then I had to spend a few hours to
figure out why latest gtk was breaking the UI tests. It looks like we
are breaking accessibility in sugar-session. If I understand things
correctly, what we do on first start is basically:

Show the intro
gtk.main()
gtk.main_quit()

[Accessibility is broken here because gtk 3.6 shuts it down]

Show the main UI
gtk.main()
gtk.main_quit()

Nested loops are supported in gtk but I suspect quitting all the loops
and then starting a new one is not (at least that's what I would guess
from the code and I can't think of a reasonable use case for it). If
that's the case this might be causing other issues.

I would be surprised if we really need two loops like that but I will
take a better look when I'm less tired :)

On 5 November 2012 19:10, Manuel Quiñones <manuq at laptop.org> wrote:
> 2012/11/5 Daniel Narvaez <dwnarvaez at gmail.com>:
>> On 5 November 2012 14:40, Manuel Kaufmann <humitos at gmail.com> wrote:
>>> On Mon, Nov 5, 2012 at 8:55 AM, Daniel Narvaez <dwnarvaez at gmail.com> wrote:
>>>>> Also would be nice to update pygobject and others, and use them from
>>>>> packages now that there are for both Fedora and Ubuntu.
>>>>
>>>> Are these packaged for Fedora 17? We don't have support for Fedora 18
>>>> in sugar-build yet but I'm planning to add it next week, when the beta
>>>> is released (assuming it does work in a vm).
>>>
>>> That's the problem. I didn't find the latest version of pygobject and
>>> gtk built for Fedora 17. I think we should update the commit hash on
>>> the sugar-build tool to get the latest version and compile it as we
>>> are doing now with an older version.
>>
>> Yeah, I will do that.
>
> Yes, sorry, I now see there is no gtk 3.6 package for F17.
>
> --
> .. manuq ..



-- 
Daniel Narvaez