[Sugar-devel] [PATCH InfoSlicer v2] Export content as HTML SL #3608

[James Cameron]

On Wed, May 23, 2012 at 02:20:43PM -0300, Manuel Kaufmann wrote:
> My question was about this case for example. I've already pushed the
> patch as we discussed in IRC, so what I have to do know to include
> your "Reviewed-by" line in the commit message?

I'm guessing here.  Check out a branch using the hash just before your
patch, apply your patch, then repeat the commit, then fast-forward
merge to master, then push.  The revised patch will be included in the
remote git repository.

It is much easier to wait for review, or push your yet to be reviewed
patches to a different branch than master.

Rhetorical: Why the urgency to push?  Once you can list your reasons
for pushing, you can find alternatives.  For instance, I like to push
so that there is an offsite backup ... but the alternative is to use
the mailing list post as a backup.  Another reason I like to push is
so that I don't have to rebase if someone else pushes.  Beat them to
it.  ;-)

But if you are the maintainer, you get to choose when to push.

-- 
James Cameron
http://quozl.linux.org.au/