[Sugar-devel] [PATCH 1/2] Fix for displaying filename in untitled PDFs SL #3597

[Manuel Quiñones]

This patch moves the line that sets the title to the
filename of the PDF, so we display "Loading..." until we
know the title, and if title is None, we show the filename.

Signed-off-by: Manuel Quiñones <manuq at laptop.org>
---
 pdfviewer.py |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pdfviewer.py b/pdfviewer.py
index ef6a6ea..cf435d6 100644
--- a/pdfviewer.py
+++ b/pdfviewer.py
@@ -289,8 +289,6 @@ class PDFTabPage(Gtk.HBox):
         # The title may be given from the Journal:
         if title is not None:
             self._browser.props.title = title
-        else:
-            self._browser.props.title = os.path.basename(requested_uri)
 
         self._browser.props.uri = requested_uri
         self._browser.props.load_status = WebKit.LoadStatus.PROVISIONAL
@@ -335,6 +333,8 @@ class PDFTabPage(Gtk.HBox):
         pdf_title = self._evince_viewer.get_pdf_title()
         if pdf_title is not None:
             self._browser.props.title = pdf_title
+        else:
+            self._browser.props.title = os.path.basename(self._requested_uri)
 
     def _get_path_from_journal(self, journal_uri):
         """Get the system tree URI of the file for the Journal object."""
-- 
1.7.10.1