[Sugar-devel] [PATCH InfoSlicer] File pep8-ized

[Anish Mangal]

On Fri, May 18, 2012 at 3:17 AM, Manuel Kaufmann <humitos at gmail.com> wrote:
> On Thu, May 17, 2012 at 2:30 PM, Anish Mangal <anish at activitycentral.com> wrote:
>> This patch does more than what it claims :-)
>>
>> Besides making the file pep8-okay, it also cleans up some "apparently"
>> redundant code. Would be better to have them as two separate patches
>> going forward (or fix the comments for this patch atleast)
>
> This patch removed "unused imports", "whitespaces" and some more pep8 things.
>
> What's the redundant code that you mention?
>

redundant code = "unused imports"

style fixes, comments = pep8 things

>> Also, could you tell which version (or git #) should this patch be
>> applied on top of. It doesnt apply cleanly on Infoslicer-14 downloaded
>> from ASLO.
>
> This patch is now obsolete, because we decided to not apply it so we
> can include InfoSlicer in the next release. We will pep8-ize this .py
> files next month, after the release.
>

ok

> Thanks.
>
> --
> Kaufmann Manuel
> Blog: http://humitos.wordpress.com/
> Porfolio: http://fotos.mkaufmann.com.ar/
> PyAr: http://www.python.com.ar/

--
Anish