[Sugar-devel] [PATCH Terminal 2/2] The same tabs as the Browse Activity

[Gonzalo Odiard]

The issue with using the browse object, is have the same colors in the
theme,
and the colors are applied to this particular class.
Probably is a good moment to think if should not be applied to the
Notebook, or create a more general class like SugarNotebook.
I think these ports will be great to help us to found a lot of these issues.

Gonzalo


On Tue, May 15, 2012 at 11:09 AM, Manuel Kaufmann <humitos at gmail.com> wrote:

> Hello,
>
> On Mon, May 14, 2012 at 4:32 PM, Agustin Zubiaga <aguz at sugarlabs.org>
> wrote:
> > diff --git a/terminal.py b/terminal.py
> > index 160b35d..59b4940 100644
>
> > +from widgets import BrowserNotebook, TabLabel
>
> Please, use one line per import here.
>
> > -        self._notebook = Notebook()
> > +        self._notebook = BrowserNotebook()
> > +        self._notebook.connect("tab-added", self.__open_tab_cb)
>
> Just asking: Is it OK using the name BrowseNotebook for this class?
>
> > +        tablabel = TabLabel()
> > +        tablabel.connect('tab-close', self.__close_tab_cb)
> > +        box.label = tablabel
> > +
> > +        index = self._notebook.append_page(box, tablabel)
> > +        tablabel.show_all()
>
> I would use: tab_label as variable name :)
>
> > diff --git a/widgets.py b/widgets.py
> > new file mode 100644
> > index 0000000..93d7dc0
> > +        self.set_name('browse-tab-add')
>
> This line comes from Browse that is why this has "browse" inside the
> string. Is it OK?
>
> > +        button.set_name('browse-tab-close')
>
> The same happens here.
>
>
> THANKS a lot for your patch!
>
> --
> Kaufmann Manuel
> Blog: http://humitos.wordpress.com/
> Porfolio: http://fotos.mkaufmann.com.ar/
> PyAr: http://www.python.com.ar/
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20120515/c0f35891/attachment.html>