[Sugar-devel] [PATCH Log 1/2] pep8-ized logcollect.py

[James Cameron]

On Thu, May 10, 2012 at 06:46:00PM -0300, Manuel Kaufmann wrote:
> Passed pep8.py script to remove a lot of trailling whitespaces and
> things related.

Reviewed-by: James Cameron <quozl at laptop.org>

On Thu, May 10, 2012 at 06:46:01PM -0300, Manuel Kaufmann wrote:
> When the user creates a zipfile with the log collector utility, all
> his installed activities are listed in info.txt (inside the zipfile)
> and all the sugar logs of the session are attached.

Reviewed-by: James Cameron <quozl at laptop.org>

> -        for path in glob.glob('/home/olpc/Activities/*'):
> +        home = os.path.expanduser('~')
> +        for path in glob.glob(os.path.join(home, 'Activities', '*')):
>              s += '~' + os.path.basename(path) + '\n'

This didn't look right, because of how it apparently corrupts the
name, changing /home/olpc/Activities/Terminal.activity
into ~Terminal.activity but it is how the code was before your patch.
It remains acceptable.

-- 
James Cameron
http://quozl.linux.org.au/