[Sugar-devel] [PATCH] Remove the workaround for missing gobject-introspection bindings of Rsvg

[Simon Schampijer]

On 03/20/2012 07:37 PM, Sascha Silbe wrote:
> Excerpts from Simon Schampijer's message of 2012-03-20 13:39:10 +0100:
>
>> gobject introspection bindings for librsvg have been pushed to librsvg
>> master [1] in 2.35.0, which solved [2]. We only have slight adopts to
>> make in our usage, for example we can not pass the data property
>> to the default constructor anymore and get_width and get_height is not
>> available anymore for the handle, but we can use the properties
>> instead.
>
> Yay!
>
>
>> This will work on Fedora 17 upwards.
>
> What exactly does this mean for Fedora 16 and non-Fedora systems that
> have librsvg<  2.35.0? Will Sugar refuse to work at all (because
> sugar-activity comes from sugar-toolkit-gtk3 and uses the sugar3
> modules) or will only affect activities that have been ported to GTK3?

It will only affect activities that have been ported to GTK3, if we land 
that patch they won't run with a librsvg < 2.35.0. So the 
sugar-toolkit-gtk3 and the activities that have been ported to it 
require the latest librsvg.

On the system level, sugar-toolkit-gtk3 has only been packaged for F17 
onward, so we are ok there. For people that want to do development using 
jhbuild on F16, they can apply the workaround until they move over to F17.

> [src/sugar3/graphics/icon.py]
>> @@ -64,7 +63,7 @@ class _SVGLoader(object):
>>                   logging.error(
>>                       'Icon %s, entity %s is invalid.', file_name, entity)
>>
>> -        return SugarExt.RsvgWrapper.new(icon)
>> +        return Rsvg.Hanlde.new_with_data(icon)
>
> Are you sure you tested this? If you did, please add a comment with a
> link to the upstream ticket telling them about the typo.

I just left this in to check if anybody is reading the patch as well 
carefully.

Regards,
    Simon