[Sugar-devel] Please review two important bug fixes (was: Re: [PATCH sugar] Journal detail view: don't choke on invalid 'keep' property, [PATCH sugar-datastore] Ensure we return valid internal / calculated properties)

[Simon Schampijer]

On 03/06/2012 10:24 PM, Sascha Silbe wrote:
> Excerpts from Sascha Silbe's message of 2012-01-09 12:02:12 +0100:
>> Excerpts from Sascha Silbe's message of 2011-11-02 23:28:28 +0100:
>>
>> [sugar patch]
>>> Properties of data store entries can get corrupted, e.g. due to low level
>>> crashes or running out of battery (see OLPC#11372 [1] for a real-life
>>> example). In addition any activity can - accidentally or on purpose - write
>>> data store entries with arbitrary metadata.
>> [...]
>>
>> [sugar-datastore patch]
>>> The copy in the metadata storage can get corrupted, e.g. due to low level
>>> crashes or running out of battery (see OLPC#11372 [1] for a real-life
>>> example).
>> [...]
>>
>> Ping. These two patches [1,2] are important bug fixes. Without them,
>> Sugar can be left crippled after a system crash.
>
> Can somebody review the patches so we can finally land these important
> bug fixes, please?
>
>
> Sascha
>
> [1] https://patchwork.sugarlabs.org/patch/1032/
> [2] https://patchwork.sugarlabs.org/patch/1136/

Both are fine to push with the amended description.

Regards,
    Simon