[Sugar-devel] [PATCH Read] Use Box, ButtonBox, Scrollbar instead of his deprecated form

[Agustin Zubiaga Sanchez]

Hi, James

sorry, I didn't want to do it.
Can you remove it?

2012/6/27 Rafael Ortiz <rafael at activitycentral.com>

>
>
> On Tue, Jun 26, 2012 at 9:20 PM, James Cameron <quozl at laptop.org> wrote:
>
>> Thanks for the patch.  I have review comments for one change:
>>
>> On Tue, Jun 26, 2012 at 10:53:57PM -0300, Agustin Zubiaga wrote:
>> > [...]
>> > diff --git a/readtopbar.py b/readtopbar.py
>> > index d0da3d0..b6fe196 100644
>> > --- a/readtopbar.py
>> > +++ b/readtopbar.py
>> > @@ -33,15 +33,16 @@ _UP_DEVICE_IFACE = 'org.freedesktop.UPower.Device'
>> >  _UP_TYPE_BATTERY = 2
>> >
>> >
>> > -class _TopBar(Gtk.HBox):
>> > +class _TopBar(Gtk.Box):
>> >      __gproperties__ = {
>> >          'completion-level': (float, None, None, 0.0, 100.0, 0.0,
>> >                               GObject.ParamFlags.WRITABLE),
>> >      }
>> >
>> >      def __init__(self):
>> > -        Gtk.HBox.__init__(self)
>> > +        Gtk.Box.__init__(self)
>> >
>> > +        self.set_orientation(Gtk.Orientation.VERTICAL)
>> >          self.set_border_width(int(style.DEFAULT_SPACING / 2.0))
>> >          self.set_spacing(style.DEFAULT_SPACING * 4)
>> >
>>
>> In this change you move from an Horizontal Box to a Box, but set the
>> orientation to vertical.  I could not tell if this was desired.  If
>> this is a desired change, perhaps it should be mentioned in the patch
>> comment.
>>
>> The other changes looked fine.
>>
>>
> Same comment as James, other than that is +1.
> .
>
>
>
>>  --
>> James Cameron
>> http://quozl.linux.org.au/
>> _______________________________________________
>> Sugar-devel mailing list
>> Sugar-devel at lists.sugarlabs.org
>> http://lists.sugarlabs.org/listinfo/sugar-devel
>>
>
>


--
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20120627/aeb7636f/attachment-0001.html>