[Sugar-devel] [PATCH] EventIcon: Have a default create_palette method

[Benjamin Berg]

On Thu, 2012-06-21 at 10:52 +0200, Simon Schampijer wrote:
> The create_palette mechanism allows to create
> palettes on demand and not for each icon upfront
> whether it will be needed or not.
> 
> If you hover over an EventIcon and there is no
> palette already associated with the Invoker, the Invoker
> will call create_palette to see if it can be created
> on demand. With this patch the EventIcon will return None
> here (see as well CellRendererIcon or ToggleToolButton which
> are having the same default behavior).
> When subclassing EventIcon the create_palette method can
> be overwritten and a Palette returned (see for example
> the ActivityIcon in the HomeView).
> 
> Without this patch you can see tracebacks when hovering
> over the EventIcon because the Invoker tries to call
> create_palette.

Duck typing at its best. Of course EventIcon needs to implement the
function.

> Signed-off-by: Simon Schampijer <simon at laptop.org>
Reviewed-by: Benjamin Berg <benzea at sugarlabs.org>