[Sugar-devel] [PATCH Get Books] Port to Gtk3 SL #3681

[Manuel Kaufmann]

On Wed, Jun 20, 2012 at 2:10 AM, Gonzalo Odiard <gonzalo at laptop.org> wrote:
> Yeah, I know that, Mr Humitos :)

OK. I prefer "Doc" instead of Mr :)

> You are aligning the second row with the "(". Please use 8 chars in the
> second row.

Oh, yes. I understand you. I think there is a convention about this
because many text editor align automatically the second line with "("
and I prefer that way too. I will research about this.

> There are a few notes about issues as pending, and probably were resolved
> later.

I'm not seeing what you are seeing. Sorry. Which ones are those "few
notes"? I've just read the list of "Missing / Problematic things (not
ported yet)" and I think that all of them still happening.

> UDisk is used to identify when a pendrive is connected to the xo. I am 99%
> sure is falling because you are using "import dbus" instead of "from
> gi.repository import DBus" (see below)

Good to know this.

> It's like in all the other port :)

I don't understand what you said here.

 * Should I take a look at another port that uses DBus?
 * Should I just replace the import and the rest will keep working?

> I know is not your fault. Probably gtk3 is returning differently the strings
> as gtk2.

I will take a look at this.

Thanks a lot for your comments Mr. Gonzalo, or you prefer Doc as well? ;)

Cheers,

-- 
Kaufmann Manuel
Blog: http://humitos.wordpress.com/
Porfolio: http://fotos.mkaufmann.com.ar/
PyAr: http://www.python.com.ar/