[Sugar-devel] [PATCH sugar-jhbuild] Remove obsolete fix_manifest call when building activities

Manuel Quiñones manuq at laptop.org
Wed Jun 13 08:38:00 EDT 2012


This fixes the warning that is printed when building the activities.
For example doing "./sugar-jhbuild buildone jukebox".  After applying,
the "fix_manifest command is obsolete" warning dissapears.

*** Building jukebox *** [1/1]
python setup.py fix_manifest
WARNING:root:bundle_name deprecated, now comes from activity.info
WARNING: The fix_manifest command is obsolete.
        The MANIFEST file is no longer used in bundles,
        please remove it.
python setup.py build
WARNING:root:bundle_name deprecated, now comes from activity.info


2012/6/13 Simon Schampijer <simon at schampijer.de>:
> The fix_manifest command is obsolete.
>
> Signed-off-by: Simon Schampijer <simon at laptop.org>

Reviewed-by: Manuel Quiñones <manuq at laptop.org>

> ---
>  sjhbuild/bundlemodule.py |    4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/sjhbuild/bundlemodule.py b/sjhbuild/bundlemodule.py
> index 05b24e3..e7f7e1d 100644
> --- a/sjhbuild/bundlemodule.py
> +++ b/sjhbuild/bundlemodule.py
> @@ -18,10 +18,6 @@ class BundleModule(distutils.DistutilsModule):
>         srcdir = self.get_srcdir(buildscript)
>         builddir = self.get_builddir(buildscript)
>         python = os.environ.get('PYTHON', 'python')
> -        cmd = [python, 'setup.py', 'fix_manifest']
> -        if srcdir != builddir:
> -            cmd.extend(['--build-base', builddir])
> -        buildscript.execute(cmd, cwd = srcdir, extra_env = self.extra_env)
>
>         cmd = [python, 'setup.py', 'build']
>         if srcdir != builddir:
> --
> 1.7.10.2
>
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel



-- 
.. manuq ..


More information about the Sugar-devel mailing list