[Sugar-devel] [PATCH Read] Show bookmark in the first page SL #3662

[Simon Schampijer]

Thanks Manuel for the patch.

The patch does work for me. Gonzalo knows better the Read code to do a 
proper review.

Tested-by: Simon Schampijer <simon at laptop.org>


On 05/31/2012 05:08 PM, Manuel Kaufmann wrote:
> Show the bookmark for the first page (if any) in the sidebar when the
> file is resumed from the Journal.
>
> Signed-off-by: Manuel Kaufmann<humitos at gmail.com>
> ---
>   readactivity.py |    5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/readactivity.py b/readactivity.py
> index 5e23b86..7cbe065 100644
> --- a/readactivity.py
> +++ b/readactivity.py
> @@ -834,6 +834,11 @@ class ReadActivity(activity.Activity):
>           self._view.set_current_page(current_page)
>           self._update_nav_buttons(current_page)
>
> +        # README: bookmark sidebar is not showing the bookmark in the
> +        # first page because this is updated just if the page number changes
> +        if current_page == 0:
> +            self._sidebar.update_for_page(current_page)
> +
>           # We've got the document, so if we're a shared activity, offer it
>           try:
>               if self.get_shared():