[Sugar-devel] [PATCH sugar-artwork] Add help icon for the toolbars - SL #3746

S. Daniel Francis francis at sugarlabs.org
Sat Jul 28 16:59:43 EDT 2012


2012/7/28 Manuel Quiñones <manuq at laptop.org>:
> Hey Dani,
>
> Bah, not a big deal, don't worry much about that.  SVG will be
> difficult to read anyways, I just wrapped the lines because git was
> refusing to send it with 'git send-email'.  Because there was a line
> above 900 characters long :)

Yeah, that is a long path and possibly nobody could understand the
patch well, but for example, I made a patch which changes only colours
(fill=), the patch could only have something like this:
-           fill="#333333" stroke="#FFFFFF"
+          fill="none;" stroke="#FFFFFF"
But the patch had very long, lines and turned it more hardy to read.

> Have you tested it?  If so, tell me so I can add the 'Tested-by' line,
> or do it yourself in this email.

Works, I tested it on Sugar Build, removing the help icon in Graph Plotter.

Tested-by: Daniel Francis <francis at sugarlabs.org>


More information about the Sugar-devel mailing list