[Sugar-devel] [PATCH sugar-build] Support Fedora 16

[Daniel Narvaez]

Hi Manuel,

thanks for your patch.

I prefer to not support old distributions in sugar-build, to reduce
the maintenance cost. It appears to just work right now but that
might change during the development cycle or when we make changes to
sugar-build itself (we will have to add master gtk soon for the shell
port, for example) and ensuring everything works as expected on many
distributions is very time consuming. I'd also have to setup two other
buildbot slaves for F16 and those are also quite expensive to
maintain. And when things will start breaking we would probably have
to add special cases to check-system, build certain stuff only on
certain distro, which will increase complexity and bring us back to
the sugar-jhbuild situation...

So, all in all, I prefer to be absolutely certain stuff works out of
the box for everyone on the latest distribution, at a reasonable
maintenance cost, rather than trying to support everything and failing
to do so reliably. I understand it might be annoying for some users to
have to upgrade to F17, but I think it's reasonable to accept that
limitation in exchange for reliability.

If in the future sugar development stops depending on the very cutting
edge of the GNOME stuff I think it might be possible to reasses this
decision, but unfortunately right now I don't see it coming very soon.

On 11 July 2012 21:46, Manuel Kaufmann <humitos at gmail.com> wrote:
> check-system script checks if we are on Fedora 16 and
> 'distro' variable is set to 'fedora' in this case.
>
> Signed-off-by: Manuel Kaufmann <humitos at gmail.com>
> ---
>  scripts/check-system |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/check-system b/scripts/check-system
> index 659d81e..993606f 100755
> --- a/scripts/check-system
> +++ b/scripts/check-system
> @@ -378,7 +378,8 @@ def check_distro():
>      # Fedora
>      try:
>          fedora_release = open("/etc/fedora-release").read().strip()
> -        if fedora_release == "Fedora release 17 (Beefy Miracle)":
> +        if fedora_release == "Fedora release 17 (Beefy Miracle)" \
> +           or fedora_release == "Fedora release 16 (Verne)":
>              distro = "fedora"
>      except IOError:
>          pass
> --
> 1.7.7.6
>



-- 
Daniel Narvaez