[Sugar-devel] Enable gnome-keyring to autostart in sugar-emulator

[Gonzalo Odiard]

Yeah, I have expected both sign it, if they worked together.

Daniel, in the future, add a Signed-off-by line to your patches.

Gonzalo

On Thu, Jul 5, 2012 at 3:33 AM, Sascha Silbe <silbe at activitycentral.com>wrote:

> Gonzalo Odiard <gonzalo at laptop.org> writes:
>
> > Why is
> >
> > Signed-off-by: Caspar Bothmer <caspar at activitycentral.com>
> >
> > if the patch was done by Daniel?
>
> Because Caspar changed the patch. See the kernel patch submission guide
> [1], section 12) Sign your work:
>
> >> [...] Rule (b) allows you to adjust the code, but then it is very
> >> impolite to change one submitter's code and make him endorse your
> >> bugs. To solve this problem, it is recommended that you add a line
> >> between the last Signed-off-by header and yours, indicating the
> >> nature of your changes.
>
>
> It looks odd in this case because Daniel didn't sign off his own
> patch. The kernel maintainers simply wouldn't accept a patch that isn't
> signed off by the author, but as even Daniel Drake's and Simon's patches
> aren't always signed off, I can't really enforce that rule for other
> Sugar contributors.
>
> Sascha
>
> [1] https://www.kernel.org/doc/Documentation/SubmittingPatches
> --
> http://sascha.silbe.org/
> http://www.infra-silbe.de/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20120705/77e44070/attachment.html>