[Sugar-devel] [PATCH] sl#2955: fixing the exception.

Sascha Silbe silbe at activitycentral.com
Mon Jan 23 14:29:54 EST 2012

Excerpts from Ajay Garg's message of 2012-01-20 22:23:48 +0100:

> ---
> Now, the execution takes place, only if the handle is present already
> (as per Daniel Drake).

Please put the patch description (as opposed to comments and changelog)
_above_ the marker line.

"fixing the exception" isn't a particularly useful thing to read when
browsing "git log", and there's no further information at all (besides
the ticket number). Daniel did a good job describing the issue [1], we
should use that as a basis for the patch description:

Ignore Buddy updates before receiving the initial Buddy list (fixes SL#2955)

jarabe.model.neighborhood._Account tracks buddies by setting up handlers
for Telepathy signals and requests initial state from Telepathy to
populate the Neighbourhood with Buddies and shared Activities. In order
to prevent a race condition between requesting initial (i.e. current)
state and updates to Buddies and shared Activities, the signal handlers
are connected before requesting (and receiving) the initial state.
However, this means that updates may arrive before the initial state,
i.e. before the corresponding Buddy is known to Sugar. That's perfectly
OK and we can simply ignore the update as the Buddy list we will receive
later on will already include the updated properties.

The code change is fine.


[1] https://bugs.sugarlabs.org/ticket/2955#comment:2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20120123/e97d994f/attachment.pgp>

More information about the Sugar-devel mailing list