[Sugar-devel] [PATCH browse] Append the current Sugar (Sucrose) version to the user agent

[Simon Schampijer]

On 01/23/2012 04:07 PM, Manuel Quiñones wrote:
> El día 16 de enero de 2012 08:52, Simon Schampijer
> <simon at schampijer.de>  escribió:
>> This identifier is used in ASLO to determine which activities
>> can be downloaded (ASLO is parsing the user agent of the Browser
>> to provide an appropriate activity version, if it fails to get
>> the Sugar version from the agent string, it uses the last stable version,
>> which is 0.94 at the moment).
>
> Tested, previously I got:
>
> Mozilla/5.0 (X11; Linux i686) AppleWebKit/535.4+ (KHTML, like Gecko)
> Version/5.0 Safari/535.4+
>
> Now I got:
>
> Mozilla/5.0 (X11; Linux i686) AppleWebKit/535.4+ (KHTML, like Gecko)
> Version/5.0 Safari/535.4+ Sugar Labs/0.96
>
> And works in activities.sugarlabs.org .
>
>>
>> One thing that is not perfectly handled by this patch is that we
>> need to modify the user agent for every WebView (see [1]).
>
> I don't find a problem adding the user agent to each webview, at least
> until the webkit hackers add a global setting.
>
>>
>> Furthermore we need to modify the Sugar version in Browse accordingly
>> with each Sugar release as the Sugar version is only availble in the
>> shell and not in the toolkit.
>
> I hope the tookit changes accordingly so we don't have to hardcore
> that in activities.

Yeah, maybe we should support that, not 100% sure yet.

> Acked-by: Manuel Quiñones<manuq at laptop.org>

Thanks for the review, pushed.

Simon