[Sugar-devel] [PATCH sugar-toolkit-gtk3] Window: fixup of wrong conversion introduced by pygi-convert.sh

Simon Schampijer simon at schampijer.de
Mon Jan 23 11:46:29 EST 2012

On 01/23/2012 04:47 PM, Daniel Drake wrote:
> On Thu, Jan 19, 2012 at 8:19 AM, Simon Schampijer<simon at schampijer.de>  wrote:
>> With 820efa56b9876bb418bc51d30de959775930e35c
>> gtk.gdk.x11_get_server_time(window) wasn't correctly converted
>> to GdkX11.x11_get_server_time(window). Found when tesing
>> collaboration.
> Looks good, but please make some noise about this upstream and
> reference the mail/bug URL in the commit message.
> This indicates either a bug in pygi-convert, or a bug in the naming of
> the introspected functions (having 'X11' twice in
> GdkX11.x11_get_server_time feels wrong to me).
> Thanks
> Daniel

Thanks Daniel for the review. I asked upstream (Tomeu), and he is not 
sure if changing the stripping is a good idea since it might break 
existing code (at least the Makefile to generate the gir) has not 
changed recently.

Maybe we should just fix the pygi-convert script.


More information about the Sugar-devel mailing list