[Sugar-devel] [PATCH 5/5] sl#3149: Localization fixes.

[Ajay Garg]

Posted the revised patch
(http://patchwork.sugarlabs.org/patch/1135/)

Thanks Chris.

Regards,
Ajay

On Sat, Jan 21, 2012 at 4:01 AM, Ajay Garg <ajay at activitycentral.com> wrote:

> Thanks Chris.
>
> Perhaps, if I could know the following, I would have a translation label
> in translations-with-format-specifiers.
> Else, I use a one-line-only translation label by default :-)
>
> Can the "TRANS" label string span multiple lines?
> That is, is something like ::
>
>                # TRANS: first line text
>                # second line text
>                # third line text
> correct?
>
> or it needs to be ::
>
>                # TRANS: first line text second line text third line text
>
>
> Regards,
> Ajay
>
>
> On Sat, Jan 21, 2012 at 3:51 AM, Chris Leonard <cjlhomeaddress at gmail.com>wrote:
>
>> Some are good, some are not, see below.
>>
>> On Thu, Jan 19, 2012 at 4:36 PM, Ajay Garg <ajay at activitycentral.com>
>> wrote:
>> >
>> > Signed-off-by: Ajay Garg <ajay at activitycentral.com>
>>
>> > -    return ', '.join([_('%(interface)s: %(version)s') %
>> > +    return ', '.join(['%(interface)s: %(version)s' %
>>
>> I think this is correct
>>
>> > -            alert.props.msg = _('%s') % e
>> > +            alert.props.msg = '%s' % e
>>
>> This looks good to me.
>>
>> > -        self.progress_label.props.label = _('%s of %s') %
>> (transferred, total)
>> > +        self.progress_label.props.label = '%s of %s' % (transferred,
>> total)
>>
>> I do not agree with this choice. I would leave it the way it was.
>> "of" is an English word.  Localizers can properly localize " %s of %s"
>>
>>
>> > -        label = glib.markup_escape_text(_('Transfer from %s') %
>> (nick,))
>> > +        label = glib.markup_escape_text(_('Transfer from') + ' ' +
>> nick)
>>
>> I do not agree with this choice.  Concatenation is bad i18n practice,
>> I would leave it the way it was.
>>
>> > -            label = gtk.Label(_('%s (%s)') % (size, type_description))
>> > +            label = gtk.Label('%s (%s)' % (size, type_description))
>>
>>
>> I think this is correct, I do not think "%s (%s)"  can be meaningfully
>> localized, at least not without a lot more context provided as a
>> developers comment.
>>
>>
>> > -        label = glib.markup_escape_text(_('Transfer to %s') % (nick,))
>> > +        label = glib.markup_escape_text(_('Transfer to') + ' ' + nick)
>>
>> I do not agree with this choice.  Concatenation is bad i18n practice,
>> I would leave it the way it was.
>>
>> > -            label = gtk.Label(_('%s (%s)') % (size, type_description))
>> > +            label = gtk.Label('%s (%s)' % (size, type_description))
>>
>> I think this is correct, I do not think "%s (%s)"  can be meaningfully
>> localized, at least not without a lot more context provided as a
>> developers comment.
>>
>> cjl
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20120123/54631db9/attachment.html>