[Sugar-devel] Removing hippo from Chat

[Gonzalo Odiard]

I have sent a new patch solving the issues you point.

Gonzalo

On Mon, Jan 9, 2012 at 10:24 AM, Aleksey Lim <alsroot at activitycentral.org>wrote:

> On Thu, Jan 05, 2012 at 10:47:33AM -0300, Gonzalo Odiard wrote:
> > Hi Aleksey,
> > I have addressed the pending issues, and will send the patches to
> > sugar-devel.
>
> Thanks, I've pushed your commits w/ lint polishing (see HACKING file).
>
> http://git.sugarlabs.org/chat/mainline/commit/148d0d6fd47d8eb6b3bf42d21828222ee4693082
>
> Also, there are a couple of issues:
>
>    diff --git a/chat/box.py b/chat/box.py
>    index bfc8156..b639037 100644
>    --- a/chat/box.py
>    +++ b/chat/box.py
>    @@ -69,9 +69,11 @@ class TextBox(gtk.TextView):
>             self._empty = True
>             self.palette = None
>             self._mouse_detector = MouseSpeedDetector(self, 200, 5)
>    -        self._mouse_detector.connect('motion-slow',
> self._mouse_slow_cb)
>    +        # TODO There is a mess with having sugar palette and TextView
> popup
>    +        #self._mouse_detector.connect('motion-slow',
> self._mouse_slow_cb)
>             self.modify_base(gtk.STATE_NORMAL, bg_color.get_gdk_color())
>    -        self.connect("event-after", self.event_after)
>    +        # TODO There is a mess with having sugar palette and TextView
> popup
>    +        #self.connect("event-after", self.event_after)
>             self.motion_notify_id = self.connect("motion-notify-event", \
>                     self.motion_notify_event)
>             self.connect("visibility-notify-event",
> self.visibility_notify_event)
>
> For example,
>
> * in self.event_after, the commented block references to unknow `tag`
> * having two popups (sugar palette and TextBox popup) looks messy.
> * url palette pops up even for TextBox widgets that don't have urls
>
> --
> Aleksey
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20120112/7b757009/attachment.html>