[Sugar-devel] [PATCH sugar-toolkit-gtk3] Activity: remove deprecated _shared_activity member

Simon Schampijer simon at schampijer.de
Wed Jan 11 13:57:37 EST 2012


On 11/01/12 17:53, Simon Schampijer wrote:
> Use the get_shared_activity method instead
>
> Signed-off-by: Simon Schampijer<simon at laptop.org>
> ---
>   src/sugar3/activity/activity.py |    3 ---
>   1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/src/sugar3/activity/activity.py b/src/sugar3/activity/activity.py
> index aedcae8..3c1a2f3 100644
> --- a/src/sugar3/activity/activity.py
> +++ b/src/sugar3/activity/activity.py
> @@ -962,9 +962,6 @@ class Activity(Window, Gtk.Container):
>       def get_document_path(self, async_cb, async_err_cb):
>           async_err_cb(NotImplementedError())
>
> -    # DEPRECATED
> -    _shared_activity = property(lambda self: self.shared_activity, None)
> -
>
>   class _ClientHandler(dbus.service.Object, DBusProperties):
>       def __init__(self, bundle_id, got_channel_cb):


We need to update the 'get_shared_activity' method as well, tested with 
Browse HEAD.

diff --git a/src/sugar3/activity/activity.py 
b/src/sugar3/activity/activity.py
index f772679..79c32ea 100644
--- a/src/sugar3/activity/activity.py
+++ b/src/sugar3/activity/activity.py
@@ -764,7 +764,7 @@ class Activity(Window, Gtk.Container):

          The shared activity is of type sugar3.presence.activity.Activity
          """
-        return self._shared_activity
+        return self.shared_activity

      def get_shared(self):
          """Returns TRUE if the activity is shared on the mesh."""

Regards,
    Simon


More information about the Sugar-devel mailing list