[Sugar-devel] [PATCH browse] Improve session store and restore

Simon Schampijer simon at schampijer.de
Wed Jan 4 04:59:48 EST 2012

On 04/01/12 03:57, Manuel Quiñones wrote:
> This is the review from Simon Schampijer of commit
> 14102bcd65f015dcbf12d1406df8ef7ffb64d13d .
> * the sessionstore code is moved into Browser, we do have
>    set_history_index/get_history_index already there, the TabbedView
>    does use that path for their requests about the history
> * Rename a few bits s/session/history and the return value from
>    self.get_back_forward_list() Use back_forward_list as variable
> * Fold _get_history and _set_history into their appropriate 'mother'
>    methods
> * Make set_history_index a bit cleaner, the API provided by webkitgtk
>    does not seem to cleanly allow our usage like:
>    get_current_item_index and go_to_back_forward_item(index) also the
>    API does seem to miss a back_forward_list.get_length() (see the code
>    we have to do in _items_history_as_list) there only exist a
>    back_forward_list.get_back_length() and
>    back_forward_list.get_forward_length().
> Signed-off-by: Manuel Quiñones<manuq at laptop.org>

Looks good, let's get it in!


More information about the Sugar-devel mailing list