[Sugar-devel] [PATCH clock] Port to Cairo

[Gary Martin]

Hi Manuel,

On 22 Feb 2012, at 17:57, Manuel Quiñones wrote:

> Hi Gary,
> 
> El día 21 de febrero de 2012 19:54, Gary Martin
> <garycmartin at googlemail.com> escribió:
>> Hi Manuel,
>> 
>> Can you confirm the version of Clock this patch is for, or if it needs other
>> patches applied first? I just tried to apply it to a v7 clone fresh from git
>> and get this:
> 
> they work for me, I also had issues while patching from gmail before,
> so I'm attaching the patches to this email.
> 
> "git am patch-name" should do the trick with the latest Clock from git.

Thanks yes the patch you attached applied just fine – and previously I did copy/paste from gmail so this email patch workflow is pretty broken for me :( I'll need to look and see if I can dance around whatever google is doing to the patch text. I wonder if we could revert to using the Gitorious workflow for Activities, the flood of email patches and re-submissions has never really worked for me (luckily I can just ignore the vast majority of that email). FWIW the Gitorious workflow is pretty much:

- log in and visit a rep

	http://git.sugarlabs.org/clock

- click the Add repository button

- make a local git clone of your new clock rep

- hack on your local clone, commit, push as desired 

- once happy, click the Gitorious Merge request button

It's so much easier for me to review syntax coloured, formatted patches, and see the various commit steps one by one if your changes are quite numerous, and then Gitorious gives me the single git command line needed to merge in your changes with all the correct 'who did what and when' details.

> The first one, basing Clock in Cairo, is a very nice improvement for
> the graphics.  Also, it prepares Clock for GTK+ 3 port.

Fab. Looks lovely, but a few issues when testing (I will try and fix them, but just wanted to mention so you are aware):

1) Analogue clock number font now much smaller than before (visible, but too small)

2) The Nice Clock mode is _very_ slow, it takes about 5sec to update on an XO-1.75, blocking the UI in between redraws

3) Digital Clock mode number fonts much smaller than previously (visible, but too small)

> The second is
> a feature that may need more discussion, I'm open to make it better if
> you think so.

Not had a chance to look at your implementation of this, but I'm 100% behind this feature and landing it ASAP. I'd also like to see if we can add a quiz mode for learning to read the time.

Thanks for the patches!

Regards,
--Gary

> Regards,
> 
> -- 
> .. manuq ..
> <0001-Port-to-Cairo.patch><0002-New-feature-grab-the-hands-of-the-clock.patch>