[Sugar-devel] [PATCH sugar] Use the new toolbars in the Journal

Simon Schampijer simon at schampijer.de
Tue Aug 28 03:43:51 EDT 2012


Great, looking good! Thanks Gonzalo and Manuel.

For the description, maybe:

Sugar has switched to a new toolbar design in 0.86 [1]. In 
sugar-toolkit-gtk3 support for the old deprecated toolbar has been 
removed in 0.96 [2]. Prior to the shell port we have to use the new 
style toolbar
in the Journal as well.

[1] http://wiki.sugarlabs.org/go/0.86/Notes#What.27s_new_for_developers
[2] http://wiki.sugarlabs.org/go/0.96/Notes#API


On 08/27/2012 03:21 PM, Manuel Quiñones wrote:
> Initial patch provided by Gonzalo Odiard for the shell port.
>
> Signed-off-by: Manuel Quiñones <manuq at laptop.org>
> ---

Two small hickups:

diff --git a/src/jarabe/journal/journaltoolbox.py 
b/src/jarabe/journal/journaltoolbox.py
index 70e58ac..21ba9c3 100644
--- a/src/jarabe/journal/journaltoolbox.py
+++ b/src/jarabe/journal/journaltoolbox.py
@@ -38,7 +38,6 @@ from sugar.graphics.icon import Icon
  from sugar.graphics.xocolor import XoColor
  from sugar.graphics.alert import Alert
  from sugar.graphics import iconentry
-from sugar.graphics import style
  from sugar import mime

  from jarabe.model import bundleregistry
@@ -66,7 +65,6 @@ _ACTION_MY_CLASS = 2


  class MainToolbox(ToolbarBox):
-    __gtype_name__ = 'SearchToolbar'

      __gsignals__ = {
          'query-changed': (gobject.SIGNAL_RUN_FIRST, gobject.TYPE_NONE,

All, the rest looks good, acked by me
    Simon



More information about the Sugar-devel mailing list