[Sugar-devel] [PATCH sugar] Remove _MouseListener from the frame - SL #3820

[Simon Schampijer]

On 08/22/2012 04:40 PM, Manuel Quiñones wrote:
> 2012/8/22 Simon Schampijer <simon at schampijer.de>:
>> On 08/21/2012 02:50 PM, Manuel Quiñones wrote:
>>>
>>> - Move the code of mouse_enter() method to a oneliner in the client class,
>>>     so a class is not needed anymore.
>>>
>>> - Fix calls to non existant mouse_leave() method from commit 238338d4 .
>>>
>>> Signed-off-by: Manuel Quiñones <manuq at laptop.org>
>>
>>
>> Thanks Manuel for the patch.
>>
>> For dragging I think the behavior should be:
>>
>> Steps:
>>
>> - I reveal the frame (hot corner, gesture, key)
>>
>> - I drag something onto the Clipboard
>>
>> - the Frame stays visible unless I hide it explicitly (hot corner, gesture,
>> key)
>>
>> Steps 2:
>>
>> - I drag something
>>
>> - while dragging I reveal the Frame over a hot corner and drop it in the
>> clipboard
>>
>> ---> in that operation the Frame has been revealed, so it should stay
>> visible after I finished the drop
>>
>> Currently in your patch the Frame hides after the drop. There is a bit of
>> more cleanup we can do. I will follow up if we agree on my described
>> behavior.
>
> Agreed in those two test cases.  Yes this need more work.
>
> Thanks!

Ok, cleaned up the unused code, and make sure the behavior from above 
works now and that the other Frame interaction still works. Hope you can 
get to the same results with the patch v2 :)

Cheers,
    Simon