[Sugar-devel] [PATCH sugar] Clipboard, drag&drop: keep notification icon up-to-date, SL #3818

[Manuel Quiñones]

Good catch, the fix makes sense.  Now I'll go for the TypeError in #3819 .

2012/8/21 Simon Schampijer <simon at schampijer.de>:
> When we drag&drop an object we do set the completion percentage to 100
> when the drop begins [1]. This creates the Notification icon right at the
> beginning when the data type has not been determined yet [2]. The
> Clipboard icon itself we keep on updating when the state changes [3].
>
> This patch does update the Notification icon on state changes like we do
> for the Clipboard icon. This patch needs Manuel's fix for SL #3811
> in order to be verified.
>
> [1] http://git.sugarlabs.org/sugar/mainline/blobs/master/src/jarabe/frame/clipboardtray.py#line184
> [2] http://git.sugarlabs.org/sugar/mainline/blobs/master/src/jarabe/frame/clipboardicon.py#line137
> [3] http://git.sugarlabs.org/sugar/mainline/blobs/master/src/jarabe/frame/clipboardicon.py#line123
>
> Signed-off-by: Simon Schampijer <simon at laptop.org>

Acked-by: Manuel Quiñones <manuq at laptop.org>

> ---
>  src/jarabe/frame/clipboardicon.py | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/jarabe/frame/clipboardicon.py b/src/jarabe/frame/clipboardicon.py
> index ebf3ad1..4baf844 100644
> --- a/src/jarabe/frame/clipboardicon.py
> +++ b/src/jarabe/frame/clipboardicon.py
> @@ -121,6 +121,8 @@ class ClipboardIcon(RadioToolButton):
>
>          if cb_object.get_icon():
>              self._icon.props.icon_name = cb_object.get_icon()
> +            if self._notif_icon:
> +                self._notif_icon.props.icon_name = self._icon.props.icon_name
>          else:
>              self._icon.props.icon_name = 'application-octet-stream'
>
> --
> 1.7.11.4
>
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel



-- 
.. manuq ..