[Sugar-devel] [PATCH sugar] SpreadLayout: do not remove items from the grid if there is none yet, SL #3814

Simon Schampijer simon at schampijer.de
Mon Aug 20 14:26:06 EDT 2012


On 08/20/2012 05:45 PM, Manuel Quiñones wrote:
> Good fix.  I was seeing this issue of not initialized grid in the
> shell port too.
>
> 2012/8/19 Simon Schampijer <simon at schampijer.de>:
>> A grid is added to the ViewContainer when the children
>> are allocated, we can not do it earlier because we need to
>> pass the allocation details. The allocation happens when
>> the children needs to be shown. Therefore if the container
>> and it's children have not been shown yet, removing the
>> child from the grid would fail.
>>
>> This patch does check if a grid exists already before trying
>> to remove items from it.
>>
>> Signed-off-by: Simon Schampijer <simon at laptop.org>
>
> Acked-by: Manuel Quiñones <manuq at laptop.org>

Thanks for the quick review. Pushed, is part of the 'no-hippo' release 
0.97.1.

Simon


More information about the Sugar-devel mailing list