[Sugar-devel] [sugar 0.98 PATCH v2] sl#3800: In "My Settings" -> "ModemConfiguration", convert the procedure to process the results of "connection.get_secrets('gsm', _secrets_cb, _secrets_err_cb)" from pseudo-asynchronous to asynchronous.

[James Cameron]

Thanks.

On Mon, Aug 13, 2012 at 10:51:59AM +0530, Ajay Garg wrote:
> @@ -59,12 +61,6 @@ def get_modem_settings():
>      # must be called asynchronously as this re-enters the GTK main loop

Is this comment in the context still held to be true, given that you
have removed the call to the GTK main loop immediately below?

>      connection.get_secrets('gsm', _secrets_cb, _secrets_err_cb)
>  
> -    # wait til asynchronous execution completes
> -    while not secrets_call_done[0]:
> -        gtk.main_iteration()
> -
> -    return modem_settings
> -

If not, fix the comment.

-- 
James Cameron
http://quozl.linux.org.au/