[Sugar-devel] [sugar-toolkit-gtk3] Replace signal used in UnfullscreenButton to enable use with touch - SL #3798

[Manuel Quiñones]

Thanks Gonzalo,

2012/8/9  <godiard at sugarlabs.org>:
> From: Gonzalo Odiard <godiard at gmail.com>
>
> Use clicked instead of button-pressed, because this is not triggered
> by touch device.

Makes sense, clicked is more general than button-pressed.  From the
docs, "is emitted when the button has been activated (pressed and
released)".

http://developer.gnome.org/gtk3/stable/GtkButton.html#GtkButton-clicked

> Signed-off-by: Gonzalo Odiard <gonzalo at laptop.org>

Acked-by: Manuel Quiñones <manuq at laptop.org>

> ---
>  src/sugar3/graphics/window.py | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/src/sugar3/graphics/window.py b/src/sugar3/graphics/window.py
> index 2d9764d..23a8d4f 100644
> --- a/src/sugar3/graphics/window.py
> +++ b/src/sugar3/graphics/window.py
> @@ -65,8 +65,8 @@ class UnfullscreenButton(Gtk.Window):
>          self._button.show()
>          self.add(self._button)
>
> -    def connect_button_press(self, cb):
> -        self._button.connect('button-press-event', cb)
> +    def connect_button_clicked(self, cb):
> +        self._button.connect('clicked', cb)
>
>      def _reposition(self):
>          x = Gdk.Screen.width() - self._width
> @@ -114,8 +114,8 @@ class Window(Gtk.Window):
>          self._is_fullscreen = False
>          self._unfullscreen_button = UnfullscreenButton()
>          self._unfullscreen_button.set_transient_for(self)
> -        self._unfullscreen_button.connect_button_press(
> -            self.__unfullscreen_button_pressed)
> +        self._unfullscreen_button.connect_button_clicked(
> +            self.__unfullscreen_button_clicked)
>          self._unfullscreen_button_timeout_id = None
>
>      def reveal(self):
> @@ -253,7 +253,7 @@ class Window(Gtk.Window):
>              return True
>          return False
>
> -    def __unfullscreen_button_pressed(self, widget, event):
> +    def __unfullscreen_button_clicked(self, button):
>          self.unfullscreen()
>
>      def __motion_notify_cb(self, widget, event):
> --
> 1.7.11.2
>
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel



-- 
.. manuq ..