[Sugar-devel] [PATCH sugar 1/7] SugarEventIcon: Add a hippo-free implementation of the CanvasIcon

[Sascha Silbe]

Benjamin Berg <benzea at sugarlabs.org> writes:

>  Reviewed-by: Benjamin Berg <benzea at sugarlabs.org>

Thanks!


>> +        # HACK to supress the grey background around the icon
>> +        # won't be needed in GTK3
>> +        self.modify_bg(gtk.STATE_NORMAL, style.COLOR_WHITE.get_gdk_color())
>
> Not really too bad, but I am pretty sure that
> gtk.EventBox.set_visible_window(False) should work fine here.

Doesn't look that way to me:
-------------- next part --------------
A non-text attachment was scrubbed...
Name: eventicon-set-window-visible-false.png
Type: image/png
Size: 19786 bytes
Desc: garbled Sugar Home View when using self.set_visible_window(False) in EventIcon
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20120806/6cf9e25e/attachment-0001.png>
-------------- next part --------------

So for the original patch:

Acked-by: Sascha Silbe <silbe at activitycentral.com>

Sascha
-- 
http://sascha.silbe.org/
http://www.infra-silbe.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 489 bytes
Desc: not available
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20120806/6cf9e25e/attachment-0001.pgp>