[Sugar-devel] [PATCH Help v3] Migrated to Gtk3 and WebKit.WebView SL #3466

[Gonzalo Odiard]

Humitos,
We need a way to keep the code consistent.
We are using the pep8 utility and the pylint utility
to try to achieve it.
That is the reason because we use one import by line,
may be you are right and is a bug in the utility,
but should be solved in the utility, if is important for you,
please report and solve it.
In the mean time, is not logic request every maintainer check every
pep8 specification for every patch.
Really, in most cases,  are conventions, does not have sense,
and is a lost of time discuss all this.

Gonzalo


On Wed, Apr 25, 2012 at 9:52 PM, Manuel Kaufmann <humitos at gmail.com> wrote:

> 2012/4/25 Manuel Quiñones <manuq at laptop.org>:
> > That's PEP8.  However, is up to the maintainer to decide.  I was just
> > trying to be helpful and give the same advices that were given to me
> > while hacking activities.  Now I see this discussion is getting
> > pointless :/
>
> Yes, I think this discussion IS important.
>
> I wasn't criticizing you, in fact I want to know why did you decide
> that. I guess that if you decide something is because a particular
> reason(s) and we can learn about that/those reason(s).
>
> Consistency is a good answer but
>  * Why use a line per import?
>  * What are the pros and cons?
>  * Did you discuss this?
>
> That is why I was "worried" in some point.
>
> On the other hand, if we decide use an import per line from now on we
> should write this down in the wiki.
>
> --
> Kaufmann Manuel
> Blog: http://humitos.wordpress.com/
> Porfolio: http://fotos.mkaufmann.com.ar/
> PyAr: http://www.python.com.ar/
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20120425/555a7eca/attachment.html>