[Sugar-devel] [PATCH 1/2] Backport "Add DescriptionEntry to the activity sub-toolbar" from sugar-toolkit-gtk3

[Simon Schampijer]

On 04/19/2012 09:21 PM, godiard at sugarlabs.org wrote:
> From: Gonzalo Odiard<godiard at gmail.com>
>
> This is the implementation of the 'Write to Journal anytime' feature [1].
>
> The patch itself adds a DescriptionItem to the activity
> sub-toolbar to make editing a Journal entry description
> from within the activity possible. The code has the same
> error handling as the TitleEntry.
>
> After talking with teachers and the learning team,
> I found they are very excited about this feature.
> Doing this change we will have a more consistent experience
> in the activities at the release of sugar 0.96 too.
>
> The original patch was done by Simon Schampijer<simon at laptop.org>
> and Walter Bender<walter.bender at gmail.com>
>
> Signed-off-by: Gonzalo Odiard<gonzalo at laptop.org>
>
> [1] http://wiki.sugarlabs.org/go/Features/Write_to_journal_anytime

So both patches (add description entry and the removal of the naming 
alert) work fine, tested here on os7 (you need to have 
sugar-artwork-0.95.5 installed in order to see the edit-description 
icon). The option is available in the Activities with the sub-toolbar 
activity toolbar e.g. Physics, Write or Calculate.

A small nitpick with Write is that the spacer which was between [title 
entry, share button] and [export options] is now placed between [title 
entry, description option] [share button, export options]. Gonzalo, 
would be great if you could have a look if this is fixable in the 
toolkit patch, or if we have to edit Write for that.

The activities without a sub-toolbar like Maze* do show the 
edit-descripton option as well.

The naming alert is not displayed anymore when closing the activity, I 
could not find any regressions introduced by this patch (it touches a 
delicate area, the saving when you close the activity), more testing 
welcome.

Some activities need custom patches to display the option, e.g. Chat or 
hello-world, but those are trivial fixes. Gonzalo will provide a full 
list of those.

Regards,
    Simon

* besides Maze having an ordering/spacing issue of the toolbar which is 
not introduced by the above patch, see SL #3474