[Sugar-devel] [PATCH v2 Browse] Store web session cookies in SQlite database, for SL #3456

[Manuel Quiñones]

El día 19 de abril de 2012 12:25, Daniel Drake <dsd at laptop.org> escribió:
> On Thu, Apr 19, 2012 at 9:20 AM, Manuel Quiñones <manuq at laptop.org> wrote:
>> There was code in Browse to create a SQlite database under data
>> directory in the activity profile.  This was for creating a cookie to
>> authenticate the laptop with a schoolserver.
>>
>> Now we use the same database via the Soup library to store all cookies
>> so they are persistent between sessions.  A Soup cookie jar is being
>> attached to the WebKit session, cookies are stored in a Mozilla
>> compatible SQLite format.
>>
>> The schoolserver function has been changed to use the Soup API.
>>
>> The code is based in Epiphany, embed/ephy-embed-single.c .
>
> Great! Looks a lot better, and now even results in a code reduction. Thanks.
>
> Just one more small detail (sorry, forgot to mention in last mail)
>
> Instead of using .new() to construct objects it is preferred to use
> the gobject constructor. You have 2 cases of using .new().
> http://wiki.sugarlabs.org/go/Features/GTK3/Porting#Constructor_considerations
>
> In some cases (when the library is buggy), this changes behaviour, so
> be sure to test it.

OK! Will do so.

-- 
.. manuq ..