[Sugar-devel] [PATCH sugar] Don't treat SSID as UTF-8 character sequence (fixes SL#2023)

Simon Schampijer simon at schampijer.de
Wed Apr 18 17:38:39 EDT 2012


On 04/17/2012 11:42 PM, Martin Langhoff wrote:
> On Mon, Apr 16, 2012 at 3:33 AM, Simon Schampijer<simon at schampijer.de>  wrote:
>> Thanks for the patch, looks good. I tested here with my AP that does
>> announce in non utf-8 char and it works fine.
>
> Cool! Great stuff.
>
> What does your funny-chars AP read like in the UI with this patch?

It displays the correct characters, the non ascii ones in non utf-8 
format. Before Sugar was not able to display it, the Palette text was 
empty and you could not connect to it (dbus error).

> We have the short term fix, and now the long term fix is landing. Aye.

And when we port the shell we can use the solution offered by nm-lib, so 
we are well equipped.

> About the nulls in the middle of the ESSID -- I hope that the kernel
> drivers know how to handle ESSIDs internally (hopefully using an array
> of bytes instead of a null-terminated string).
>
> Userland, OTOH, will be more prone to problems with nulls I suspect.
> The ESSID will come from a a config file (where usually nulls are not
> supported), or from a cmdline parameter, where's C-style string
> handling will have trouble with the nulls.
>
>
>
>
> m

I hope so, too :/

Regards,
    Simon


More information about the Sugar-devel mailing list