[Sugar-devel] [PATCH sugar] Fix shortcut for view source

[Simon Schampijer]

On 04/16/2012 04:02 PM, Sascha Silbe wrote:
> Excerpts from Simon Schampijer's message of 2012-04-16 10:42:39 +0200:
>
> [extensions/globalkey/viewsource.py]
>> -BOUND_KEYS = ['0xEC', '<alt><shift>v']
>> +BOUND_KEYS = ['XF86KbdLightOnOff', '<alt><shift>v']
>
> Is "Keyboard light on/off" really a key that we want to trigger View
> Source? Maybe it's what current OLPC images call the key, but that's
> fixable.
>
> If upstream (Linux) really is averse to adding a new definition for the
> "gear" key, the following existing one [1] sounds like a better fit:
>
> KEY_PROPS ("Display the properties of the current document" [2])
>
>
> That key would be better mapped to opening the Journal details view (for
> the current activity session), but if there's really push-back from the
> input subsystem maintainers, it would be a reasonable compromise.
>
> Sascha
>
> [1] https://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob_plain;f=include/linux/input.h;hb=HEAD
> [2] https://www.usb.org/developers/devclass_docs/Hut1_12v2.pdf (section 15.16)

I guess 'XF86WebCam' for 'open_search' or 'XF86MenuKB' for the 'frame' 
is not much better [1]. Not saying that those are good names but if you 
want to have proper names you should change them all, but...

This is only a temporary solution. See [2] and [3] for using 
gtk_accelerator_parse() or its more flexible variant 
gtk_accelerator_parse_with_keycode() when we port the shell.

Hope that makes it clearer,
    Simon

[1] 
http://git.sugarlabs.org/sugar/mainline/commit/26df35b0c02881864d0f47782f8ff5b5ce5e187c
[2] https://bugzilla.gnome.org/show_bug.cgi?id=672950#c1
[3] http://bugs.sugarlabs.org/ticket/3412