[Sugar-devel] [PATCH] PATCH for Words Activity that fix https://dev.laptop.org.au/issues/1078 Speak option says the word twice in words activity.

[Rafael Ortiz]

2012/4/17 Manuel Quiñones <manuq at laptop.org>

> El día 17 de abril de 2012 12:53, Rafael Ortiz
> <rafael at activitycentral.com> escribió:
> >
> >
> > On Tue, Apr 17, 2012 at 10:41 AM, Ariel Calzada <ariel.calzada at gmail.com
> >
> > wrote:
> >>
> >> On 04/17/2012 10:31 AM, Ariel Calzada wrote:
> >>>
> >>> PATCH for Words Activity that fix
> https://dev.laptop.org.au/issues/1078
> >>> Speak option says the  word twice in words activity.
> >>>
> >>> ---
> >>>  wordsactivity.py |    9 ++-------
> >>>  1 files changed, 2 insertions(+), 7 deletions(-)
> >>>
> >>> diff --git a/wordsactivity.py b/wordsactivity.py
> >>> index 5c241f7..cfb8794 100644
> >>> --- a/wordsactivity.py
> >>> +++ b/wordsactivity.py
> >>> @@ -201,20 +201,15 @@ class WordsActivity(activity.Activity):
> >>>          # No Portuguese accent yet.
> >>>          if lang == "portuguese":
> >>>              lang = "spanish"
> >>> -        tmpfile = "/tmp/something.wav"
> >>> -        subprocess.call(["espeak", text, "-w", tmpfile, "-v", lang])
> >>> -        subprocess.call(["aplay", tmpfile])
> >>> -        os.unlink(tmpfile)
> >>> -
> >>>          #AU costumization
> >>> -        if lang == "english":
> >>> +        elif lang == "english":
> >>>              lang = "english_rp"
> >>> +
> >>>          tmpfile = "/tmp/something.wav"
> >>>          subprocess.call(["espeak", text, "-w", tmpfile, "-v", lang])
> >>>          subprocess.call(["aplay", tmpfile])
> >>>          os.unlink(tmpfile)
> >>>
> >>> -
> >>>      def lang1combo_cb(self, combo):
> >>>          pass
> >>>
>
> Tested, is working propery now, great.
>
> > Thanks for the catch, applied as
> >
> >
> >
> http://git.sugarlabs.org/words-activity/words-activity/commit/fb3819774867c814a65d201d5b8cdb9d4767702e
>
> Please take care before commiting, the text in the commit message is
> duplicated.
>
>
Should be git am dup. as the patch has not this duplicated text.


>  > Will be in next version.
> >
> > Thanks.
> >
> >
> >
> > _______________________________________________
> > Sugar-devel mailing list
> > Sugar-devel at lists.sugarlabs.org
> > http://lists.sugarlabs.org/listinfo/sugar-devel
> >
>
>
>
> --
> .. manuq ..
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20120417/77ee19c9/attachment-0001.html>