[Sugar-devel] [PATCH] keyhandler: Use textual key names

[Simon Schampijer]

On 03/28/2012 11:40 PM, Peter Robinson wrote:
> On Tue, Mar 27, 2012 at 9:22 PM, Daniel Drake<dsd at laptop.org>  wrote:
>> Conversion of 0x## keycodes is broken in libegg with recent GDK.
>>
>> Switch to the textual names of the keys in question to work around this
>> bug, reference:  https://bugzilla.gnome.org/show_bug.cgi?id=672950
>>
>> This fixes the frame key on XO laptops running Fedora 17.
>>
>> Signed-off-by: Daniel Drake<dsd at laptop.org>
>> ---
>>   src/jarabe/view/keyhandler.py |    4 ++--
>>   1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/jarabe/view/keyhandler.py b/src/jarabe/view/keyhandler.py
>> index a71f260..530da75 100644
>> --- a/src/jarabe/view/keyhandler.py
>> +++ b/src/jarabe/view/keyhandler.py
>> @@ -51,11 +51,11 @@ _actions_table = {
>>      'XF86AudioRaiseVolume': 'volume_up',
>>      '<alt>F11': 'volume_min',
>>      '<alt>F12': 'volume_max',
>> -    '0x93': 'frame',
>> +    'XF86MenuKB': 'frame',
>>      '<alt>Tab': 'next_window',
>>      '<alt><shift>Tab': 'previous_window',
>>      '<alt>Escape': 'close_window',
>> -    '0xDC': 'open_search',
>> +    'XF86WebCam': 'open_search',
>>   # the following are intended for emulator users
>>      '<alt><shift>f': 'frame',
>>      '<alt><shift>q': 'quit_emulator',
>
> I think we need a similar fix for the Fn key, I gett repeating = signs
> on a 1.75-HS and it doesn't work for pg-up dg-down on the XO-1/XO1.5
> membrane keyboard.
>
> Peter

In os7 I can use fn+pg-up/pg-down fine (tested with membrane keyboard 
with a XO-1.5). But there was one shortcut missing indeed in the 
conversion, the one for the view source: 
http://lists.sugarlabs.org/archive/sugar-devel/2012-April/036655.html

Thanks for productively noising,
    Simon