[Sugar-devel] [PATCH Chat v4] Scroll the chat log

[James Cameron]

On Thu, Apr 12, 2012 at 09:13:54AM -0300, Manuel Kaufmann wrote:
> On Thu, Apr 12, 2012 at 02:38, Aleksey Lim <alsroot at sugarlabs.org> wrote:
> > I only added "#2782" to commit title to make it possible to see ticket
> > number from short log. And, replaced
> 
> Good! I missed it. Thanks!
> 
> > ?? ??event.state == gtk.gdk.CONTROL_MASK
> >
> > by
> >
> > ?? ??event.state & gtk.gdk.CONTROL_MASK
> 
> Could you explain what's the difference?

CONTROL_MASK isn't the only bit that might be set in event.state, there
may be other bits set as well.  So if you want to check for CONTROL_MASK
with other bits set at the same time, you must AND (&) it out, instead
of check for equality.

-- 
James Cameron
http://quozl.linux.org.au/