[Sugar-devel] [PATCH Maze] Comment bugfix and import missing

[Rafael Ortiz]

2012/4/11 Manuel Quiñones <manuq at laptop.org>

> El día 11 de abril de 2012 01:01, Rafael Ortiz
> <rafael at activitycentral.com> escribió:
> >
> >
> > 2012/4/10 Manuel Quiñones <manuq at laptop.org>
> >>
> >> El día 10 de abril de 2012 21:04, Rafael Ortiz
> >> <rafael at activitycentral.com> escribió:
> >> >
> >> >
> >> > On Tue, Apr 10, 2012 at 2:58 PM, Manuel Kaufmann <humitos at gmail.com>
> >> > wrote:
> >> >>
> >> >> On Tue, Apr 10, 2012 at 16:56, Manuel Kaufmann <humitos at gmail.com>
> >> >> wrote:
> >> >> >  - A triple quoted comment was accidentally removed, so I added it
> >> >> > again.
> >> >> >  - Added 'gtk' module because it was missing.
> >> >>
> >> >> This patch fixes these errors:
> >> >>
> >> >> Traceback (most recent call last):
> >> >>  File "/srv/sugar-jhbuild/install/bin/sugar-activity", line 146, in
> >> >> <module>
> >> >>    main()
> >> >>  File "/srv/sugar-jhbuild/install/bin/sugar-activity", line 141, in
> >> >> main
> >> >>    instance = create_activity_instance(activity_constructor,
> >> >> activity_handle)
> >> >>  File "/srv/sugar-jhbuild/install/bin/sugar-activity", line 34, in
> >> >> create_activity_instance
> >> >>    activity = constructor(handle)
> >> >>  File "/home/humitos/Activities/Maze.activity/olpcgames/activity.py",
> >> >> line 106, in __init__
> >> >>    toolbar = self.build_toolbar()
> >> >>  File "/home/humitos/Activities/Maze.activity/activity.py", line 19,
> >> >> in build_toolbar
> >> >>    separator = gtk.SeparatorToolItem()
> >> >> NameError: global name 'gtk' is not defined
> >> >>
> >> >> and
> >> >>
> >> >> Traceback (most recent call last):
> >> >>  File "/srv/sugar-jhbuild/install/bin/sugar-activity", line 146, in
> >> >> <module>
> >> >>    main()
> >> >>  File "/srv/sugar-jhbuild/install/bin/sugar-activity", line 104, in
> >> >> main
> >> >>    module = __import__(module_name)
> >> >>  File "/home/humitos/Activities/Maze.activity/activity.py", line 3,
> in
> >> >> <module>
> >> >>    import olpcgames
> >> >>  File "/home/humitos/Activities/Maze.activity/olpcgames/__init__.py",
> >> >> line 99, in <module>
> >> >>    from olpcgames.activity import PygameActivity as PyGameActivity
> >> >>  File "/home/humitos/Activities/Maze.activity/olpcgames/activity.py",
> >> >> line
> >> >> 5
> >> >>    The olpcgames.activity module encapsulates creation of a Pygame
> >> >> activity.
> >> >>                ^
> >> >> SyntaxError: invalid syntax
> >> >>
> >> >> See you,
> >> >>
> >> >
> >> >
> >> > Yes, this is due to a commit  that reverted all the way back to v15
> >> > (maybe a
> >> > pootle error), after v16 was released, so the problem is in git) next
> >> > version should be o.k.
> >>
> >> I also see several .xo files in the dist folder under git revision.
> >> That's odd because when doing new releases (using setup.py dist_xo
> >> command) they are added in the new .xo .
> >>
> >> --
> >
> >
> > The mess should be fine now :).
>
> Thanks for taking care.  However, I don't see the difficulty buttons
> anymore :(
>
>
hmm It's o.k to me.


> Would be nice to check that the activity still runs between commits :P
>
> Yes, the prob was the rollback commit that got me crazy.




> Cheers,
>
> --
> .. manuq ..
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20120411/d0d5882a/attachment-0001.html>