[Sugar-devel] [Patch Memorize]

[Gonzalo Odiard]

Hi Ariel,
A few comments about the patches:
* Is better have all the changes related to the proposed functionality in a
single patch.

* Do not do changes not related, because is harder understand the patch
like in:

                   'front_border': {'fill_color': '#4c4d4f',
                                    'stroke_color': '#ffffff',
                                    'opacity': '1'}},
-                None, theme.PAIR_SIZE, 1, '#c0c0c0')
+                None,
+                theme.PAIR_SIZE,
+                1,
+                '#c0c0c0')

or


-    def __init__(self, identifier, pprops, jpeg, size,
-                 align, bg_color='#000000'):
+    def __init__(self, identifier, pprops, jpeg, size, align,
bg_color='#000000'):

* Use a single to save the config, not one for every parameter (now we have
two parameters,
but if we add more is not a good route). Use json is a good idea.

* Check pep8

* I don't think reading the config from the file in svgcard.py is a good
idea.
Is better use a a method to set it from the other classes using it.
Having two different methods to read the config is not good.

* Remove the commented code like:

+                """
+                f = open("/tmp/cartas.txt", "a")
+                f.write("ID = " + str(self.id) + "| TEXT = " + text + "|
FONT=" + font + "|" + str(self.pprops) + "\n")
+                f.close()
+                """

Gonzalo

On Fri, Mar 30, 2012 at 3:11 PM, Ariel Calzada <ariel at activitycentral.com>wrote:

> This patch will let user change font for the cards.
>
> Use can edit game and change the font. I attach screenshots
>
> Regards,
> ARIEL CALZADA
> www.activitycentral.com
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20120404/7d2cec93/attachment.html>