[Sugar-devel] [PATCH] Remove hippo from the intro screens

Sascha Silbe sascha-ml-reply-to-2011-3 at silbe.org
Mon Sep 26 11:38:51 EDT 2011

Excerpts from Daniel Drake's message of 2011-09-17 13:30:38 +0200:
> Switch to standard GTK containers. Specific coloring details have been
> moved to the theme at the same time.
> Based on earlier work by Raul Gutierrez and Walter Bender.

Thanks for the patch! The code looks good; I haven't tried it out to
verify the layout.

[class ColorPicker]
> +    def _button_press_cb(self, widget, event):
> +        if event.button == 1 and event.type == gtk.gdk.BUTTON_PRESS:

Why do we need to check for BUTTON_PRESS here? We only subscribed to
button-press-event, so what other events could we received?

Reviewed-By: Sascha Silbe <silbe at activitycentral.com>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20110926/c4e7ad0f/attachment.pgp>

More information about the Sugar-devel mailing list